Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private harbor fix #74

Merged
merged 12 commits into from
Nov 8, 2024
Merged

Private harbor fix #74

merged 12 commits into from
Nov 8, 2024

Conversation

at88mph
Copy link
Member

@at88mph at88mph commented Oct 17, 2024

No description provided.

@at88mph at88mph requested a review from szautkin October 18, 2024 20:14
@at88mph
Copy link
Member Author

at88mph commented Oct 18, 2024

@szautkin Please look at the JavaScript changes. The Java changes are more optional.

@szautkin szautkin added REVIEWING when somebody is actually reviewing the PR CODE REVIEW The PR is ready for code review labels Oct 18, 2024
@szautkin szautkin self-assigned this Oct 18, 2024
@at88mph at88mph requested a review from szautkin November 7, 2024 19:27
szautkin
szautkin previously approved these changes Nov 7, 2024
View reviewed changes
@szautkin szautkin added CAN-MERGE and removed REVIEWING when somebody is actually reviewing the PR labels Nov 7, 2024
@szautkin szautkin removed the CODE REVIEW The PR is ready for code review label Nov 8, 2024
@at88mph at88mph merged commit 2d0bbe7 into opencadc:main Nov 8, 2024
1 check passed
@at88mph at88mph deleted the private-harbor-fix branch November 8, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jburke-cadc jburke-cadc jburke-cadc approved these changes

@szautkin szautkin szautkin approved these changes

Assignees

@szautkin szautkin

Labels
CAN-MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@at88mph @jburke-cadc @szautkin